Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt inclusive_scan to C++ 20 #5439

Merged
merged 6 commits into from Jul 30, 2021
Merged

Conversation

@Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jul 8, 2021

Adapted inclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668
Issue #5156

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_inclusive_scan branch from 6678856 to 591e991 Jul 10, 2021
@hkaiser hkaiser added this to Open Tickets in Standard Algorithms via automation Jul 11, 2021
@hkaiser hkaiser added this to the 1.8.0 milestone Jul 11, 2021
@hkaiser hkaiser mentioned this pull request Jul 15, 2021
41 of 45 tasks
#if defined(HPX_GCC_VERSION) && HPX_GCC_VERSION >= 100000
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
Comment on lines +718 to +721

This comment has been minimized.

@hkaiser

hkaiser Jul 21, 2021
Member

We should move this (and the corresponding pop below) into separate include files to reduce cluttering the code (place them here, for instance: https://github.com/STEllAR-GROUP/hpx/tree/master/libs/core/config/include/hpx/config). But that's something for a separate PR.

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_inclusive_scan branch 2 times, most recently from f6e9f1c to fc23989 Jul 23, 2021
@Jedi18 Jedi18 force-pushed the Jedi18:adapt_inclusive_scan branch from fc23989 to 7346f71 Jul 24, 2021
@jenkins-cscs
Copy link
Collaborator

@jenkins-cscs jenkins-cscs commented Jul 26, 2021

Can one of the admins verify this patch?

Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser hkaiser merged commit b2bc348 into STEllAR-GROUP:master Jul 30, 2021
26 of 33 checks passed
26 of 33 checks passed
@github-actions
build build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@circleci-checks
build-and-test Workflow: build-and-test
Details
@msimberg
jenkins/lsu/clang-9-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-cuda-11-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-cuda-11-release Jenkins
Details
@msimberg
jenkins/lsu/hipcc-debug Jenkins
Details
@msimberg
jenkins/lsu/hipcc-release Jenkins
Details
@codacy-production
Codacy Static Code Analysis A positive pull request.
Details
@jenkins-cscs
jenkins/cscs Build finished.
Details
@jenkins-cscs
jenkins/cscs-perftests Build finished.
Details
@msimberg
jenkins/cscs/clang-10 Jenkins
Details
@msimberg
jenkins/cscs/clang-8 Jenkins
Details
@msimberg
jenkins/cscs/clang-9 Jenkins
Details
@msimberg
jenkins/cscs/clang-apex Jenkins
Details
@msimberg
jenkins/cscs/clang-cuda Jenkins
Details
@msimberg
jenkins/cscs/clang-newest Jenkins
Details
@msimberg
jenkins/cscs/clang-oldest Jenkins
Details
@msimberg
jenkins/cscs/gcc-10 Jenkins
Details
@msimberg
jenkins/cscs/gcc-cuda Jenkins
Details
@msimberg
jenkins/cscs/gcc-newest Jenkins
Details
@msimberg
jenkins/cscs/gcc-oldest Jenkins
Details
@msimberg
jenkins/cscs/icc Jenkins
Details
@msimberg
jenkins/lsu/clang-9-release Jenkins
Details
@msimberg
jenkins/lsu/gcc-8-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-8-release Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-release Jenkins
Details
Standard Algorithms automation moved this from Open Tickets to Merged to master Jul 30, 2021
@hkaiser hkaiser mentioned this pull request Jul 30, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants