Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt inclusive_scan to C++ 20 #5439

Merged
merged 6 commits into from Jul 30, 2021

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jul 8, 2021

Adapted inclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668
Issue #5156

#if defined(HPX_GCC_VERSION) && HPX_GCC_VERSION >= 100000
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
Copy link
Member

@hkaiser hkaiser Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this (and the corresponding pop below) into separate include files to reduce cluttering the code (place them here, for instance: https://github.com/STEllAR-GROUP/hpx/tree/master/libs/core/config/include/hpx/config). But that's something for a separate PR.

@Jedi18 Jedi18 force-pushed the adapt_inclusive_scan branch 2 times, most recently from f6e9f1c to fc23989 Compare Jul 24, 2021
@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Jul 26, 2021

Can one of the admins verify this patch?

Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser hkaiser merged commit b2bc348 into STEllAR-GROUP:master Jul 30, 2021
26 of 33 checks passed
Standard Algorithms automation moved this from Open Tickets to Merged to master Jul 30, 2021
@hkaiser hkaiser mentioned this pull request Jul 30, 2021
9 tasks
@msimberg msimberg modified the milestones: 1.8.0, 1.7.1 Aug 6, 2021
msimberg pushed a commit that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Development

Successfully merging this pull request may close these issues.

None yet

4 participants