Adapt inclusive_scan to C++ 20 #5439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
Jedi18
force-pushed
the
adapt_inclusive_scan
branch
2 times, most recently
from
96f5a90 to
6678856
Compare
This was referenced Jul 9, 2021
Jedi18
force-pushed
the
adapt_inclusive_scan
branch
from
6678856 to
591e991
Compare
46 tasks
hkaiser
reviewed
Jul 21, 2021
libs/full/segmented_algorithms/include/hpx/parallel/segmented_algorithms/inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 21, 2021
Comment on lines
+718
to
+721
| #if defined(HPX_GCC_VERSION) && HPX_GCC_VERSION >= 100000 | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wdeprecated-declarations" | ||
| #endif |
There was a problem hiding this comment.
We should move this (and the corresponding pop below) into separate include files to reduce cluttering the code (place them here, for instance: https://github.com/STEllAR-GROUP/hpx/tree/master/libs/core/config/include/hpx/config). But that's something for a separate PR.
hkaiser
reviewed
Jul 21, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 21, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/inclusive_scan.hpp
Show resolved
Hide resolved
hkaiser
reviewed
Jul 21, 2021
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/inclusive_scan.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_inclusive_scan
branch
2 times, most recently
from
f6e9f1c to
fc23989
Compare
…ult, simplify concept expressions
Jedi18
force-pushed
the
adapt_inclusive_scan
branch
from
fc23989 to
7346f71
Compare
|
Can one of the admins verify this patch? |
msimberg
pushed a commit
that referenced
this pull request
Aug 6, 2021
Adapt inclusive_scan to C++ 20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted inclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668
Issue #5156