Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt transform_inclusive_scan to C++ 20 #5444

Merged
merged 5 commits into from Jul 30, 2021

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jul 13, 2021

Adapted transform_inclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668
Issue #5156

@Jedi18 Jedi18 force-pushed the adapt_transform_inclusive_scan branch 3 times, most recently from 4518a83 to 53d00bc Compare Jul 26, 2021
@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Jul 26, 2021

Can one of the admins verify this patch?

hkaiser
hkaiser previously approved these changes Jul 26, 2021
Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@Jedi18 Jedi18 force-pushed the adapt_transform_inclusive_scan branch from 53d00bc to 2112dc4 Compare Jul 30, 2021
@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 30, 2021

Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan

@Jedi18 Jedi18 force-pushed the adapt_transform_inclusive_scan branch from 2112dc4 to b86150d Compare Jul 30, 2021
@hkaiser hkaiser merged commit 85f256a into STEllAR-GROUP:master Jul 30, 2021
6 of 8 checks passed
@hkaiser hkaiser mentioned this pull request Jul 30, 2021
9 tasks
@msimberg msimberg modified the milestones: 1.8.0, 1.7.1 Aug 6, 2021
msimberg pushed a commit that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants