New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt rotate/rotate_copy to C++20 #5459
Conversation
Can one of the admins verify this patch? |
add to whitelist |
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
Please have an eye on the CircleCI builder (e.g. here for the latest commit: https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/8257/workflows/f940a4fb-e466-4a2c-bd70-9127024c4277) as that builder runs a couple of additional forma tests (spellcheck, clang-format, inspect) that need to pass. |
There are some suggestions from Akhil: (Thanks a lot)
--- will do. so does
|
before doing "uniform format", the commit "add exception and bad alloc tests back" could build_and_test successfully. I think this PR is ready for review. |
libs/parallelism/algorithms/include/hpx/parallel/algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/rotate.hpp
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/rotate.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the minor comments, this LGTM, thanks a lot! Good work!
Thanks, Appreciate your help! |
two more commits, finally, the build-and-test passed sucessfully. |
Let's get this merged asap, then. |
There is nothing you can do about this - it's how github handles PRs. |
got it. |
Congratulations, your first PR to the HPX repository has just been merged! As a 'thank you' we offer a free STE||AR-Group t-shirt to all of our first time contributors. If you are interested in receiving one, please get back to me directly so we can set up the delivery. |
Thanks a lot!! |
adapt rotate and rotate_copy to c++20,
add container overloads(range and sentinel),
add container tests.
Any background context you want to provide?
Adapt parallel algorithms to C++20 #4822
Parallel algorithms should accept iterator/sentinel pairs #3646