Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test release and debug builds on Piz Daint #5537

Merged

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Sep 3, 2021

No description provided.

@msimberg
Copy link
Contributor Author

msimberg commented Sep 3, 2021

retest cscs

1 similar comment
@msimberg
Copy link
Contributor Author

msimberg commented Sep 3, 2021

retest cscs

hkaiser
hkaiser previously approved these changes Sep 3, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just a question: why have you implemented this differently if compared to the LSU configuration

@msimberg
Copy link
Contributor Author

msimberg commented Sep 3, 2021

LGTM, thanks!

Just a question: why have you implemented this differently if compared to the LSU configuration

I have not, at least not intentionally. Where do you see differences?

The scripts could do with a bit of unification now, but they should do roughly the same thing. The only thing that I know is different is that on rostam we install HPX on master and release.

@hkaiser
Copy link
Member

hkaiser commented Sep 3, 2021

The scripts could do with a bit of unification now, but they should do roughly the same thing.

That's what I was referring to. On rostam the configuration scripts for the concrete CI directly refer to ${configuration_name}-${build_type} while on PizDaint you use the combined ${configuration_name_with_build_type}. No big deal, really...

@msimberg
Copy link
Contributor Author

msimberg commented Sep 3, 2021

That's what I was referring to. On rostam the configuration scripts for the concrete CI directly refer to ${configuration_name}-${build_type} while on PizDaint you use the combined ${configuration_name_with_build_type}. No big deal, really...

Could you link to it please? Both of them export configuration_name_with_build_type="${configuration_name}-${build_type,,}" and use that later on.

@hkaiser
Copy link
Member

hkaiser commented Sep 3, 2021

That's what I was referring to. On rostam the configuration scripts for the concrete CI directly refer to ${configuration_name}-${build_type} while on PizDaint you use the combined ${configuration_name_with_build_type}. No big deal, really...

Could you link to it please? Both of them export configuration_name_with_build_type="${configuration_name}-${build_type,,}" and use that later on.

You're right - I misremembered things. Please disregard my comment.

aurianer
aurianer previously approved these changes Sep 7, 2021
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg dismissed stale reviews from aurianer and hkaiser via efc085d September 8, 2021 09:04
@msimberg msimberg force-pushed the cscs-jenkins-release-debug-builds branch from 854fe7c to efc085d Compare September 8, 2021 09:04
@msimberg
Copy link
Contributor Author

msimberg commented Sep 8, 2021

Now it should actually use the build type. I didn't apply it earlier.

@msimberg
Copy link
Contributor Author

msimberg commented Sep 8, 2021

Note: Piz Daint is in maintenance today... So no builds there at the moment.

@msimberg
Copy link
Contributor Author

retest cscs

The warning only appears with optimizations enabled.
@msimberg
Copy link
Contributor Author

I've disabled a GCC warning which seems to be bogus, and only appears with optimizations enabled in GCC 11. This wasn't there before since the gcc-newest configuration (which uses GCC 11 at the moment) was only built in debug mode.

@msimberg msimberg merged commit 28f7256 into STEllAR-GROUP:master Sep 14, 2021
@msimberg msimberg deleted the cscs-jenkins-release-debug-builds branch September 14, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants