Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separately building segmented algorithms on CircleCI #5616

Merged
merged 1 commit into from Oct 20, 2021

Conversation

msimberg
Copy link
Contributor

They were being built as part of the tests.unit target already, so it's unnecessary. They were originally separated to reduce memory requirements, but that seems to no longer be a problem.

They were being built as part of the tests.unit target already, so it's unnecessary. They were originally separated to reduce memory requirements, but that seems to no longer be a problem.
@hkaiser
Copy link
Member

hkaiser commented Oct 19, 2021

Have we been building those twice all the time - silly us!

@msimberg
Copy link
Contributor Author

Have we been building those twice all the time - silly us!

No no! Once it's built it's built. The second call to ninja just doesn't do anything since tests.unit.modules.segmented_algorithms
is a subset of tests.unit.

@msimberg msimberg merged commit 0063405 into master Oct 20, 2021
@msimberg msimberg deleted the msimberg-patch-2 branch October 20, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants