New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated for_loop.hpp #5778
Updated for_loop.hpp #5778
Conversation
This fixes the issue of for_loop function taking absurd values as arguments.
…-patch Updated the for_loop.hpp
Can one of the admins verify this patch? |
libs/core/algorithms/include/hpx/parallel/algorithms/for_loop.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the test to be run you will need to modify the CMakeLists.txt here: https://github.com/STEllAR-GROUP/hpx/blob/master/libs/core/algorithms/tests/regressions/CMakeLists.txt
Also, please take care of the clang-format and inspect errors as flagged by the CI
Final Updated test file
@deepaksuresh1411 As circleCI indicates and Hartmut already mentioned you need to clang-format your files. We provide a clang-format config file (.clang-format) on the top of our repo. You should Hint: If you are using VS Code you can easily configure it to format every time you save a file. Just be careful not to use the defalt clang-format config cause tests will fail again. Moreover, check your ci/circleci: inspect errors (I don't think clang-format fixes those). It's just a bunch of redundant (or missing whitespaces). Please fix accordingly ;) |
@gonidelis I'll do it ASAP. |
formatted the code according to clang-format
Formatted the file
@hkaiser I did the clang-format , but in circle-ci tests, there is one issue related to |
Yes, that's the inspect error I referred to earlier. It asks you to add a Also, it complains about the SPDX license tag to be missing from the file (i.e. something like: https://github.com/STEllAR-GROUP/hpx/blob/master/libs/core/algorithms/include/hpx/parallel/algorithms/for_loop.hpp#L4) |
I'll, rectify it |
Just in case if you can't access the CI results, here is the compiler output generated while compiling your test (taken from here: https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/10384/workflows/43d53655-7cc1-40eb-b505-dcdd96b4d6a9/jobs/286870/steps):
Please note that the deprecation warning was added just a couple of days ago, please change your test accordingly. |
|
Seems like this is good to go. |
@gonidelis Thanks :) |
Don't think so. Let's wait for @hkaiser to verify. |
Sounds good.. |
libs/core/algorithms/include/hpx/parallel/algorithms/for_loop.hpp
Outdated
Show resolved
Hide resolved
@hkaiser is there anything else I have to do in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors merge |
👎 Rejected by code reviews |
Congratulations, your first PR to the HPX repository has just been merged! As a 'thank you' we offer a free STE||AR-Group t-shirt to all of our first-time contributors. If you are interested in receiving one, please get back to me directly so we can set up the delivery. |
@hkaiser @gonidelis @srinivasyadav18 @NK-Nikunj |
This fixes the issue #5735 of for_loop function taking absurd values as arguments.