[P2300] enhancements: receiver_of, sender_of improvements #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAtacker
force-pushed
the
p2300_enhancements
branch
2 times, most recently
from
11b532b
to
d14fc26
Compare
Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
* Using templates itself to unpack the types in a tuple within a variant. Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
- If sender supports sends_stopped (i.e. it is true) then is_receiver_of is called. - Otherwise it checks for the value_types and error_types of those - Added tests all the cases Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
SAtacker
force-pushed
the
p2300_enhancements
branch
from
22f1bbb
to
1590b49
Compare
SAtacker
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
hkaiser
added
type: enhancement
type: compatibility issue
category: senders/receivers
hkaiser
reviewed
Jun 24, 2022
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Outdated
Show resolved
Hide resolved
libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp
Show resolved
Hide resolved
1. Using `typename` instead of `class` [ref](https://github.com/STEllAR-GROUP/hpx/pull/5920/files#r906386203). 2. Use `meta::pack` instead of `hpx::variant`,`hpx::tuple` [ref](https://github.com/STEllAR-GROUP/hpx/pull/5920/files#r906385013). 3. Modify `sender_of` as per P2300 [ref](https://github.com/STEllAR-GROUP/hpx/pull/5920/files#r906393349). Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
SAtacker
force-pushed
the
p2300_enhancements
branch
from
898ed20
to
eb8bcbd
Compare
Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Atre shreyasatre16@gmail.com
Proposed Changes
receiver_ofconcept takes a receiver and an instance of thecompletion_signatures<>class template.sender_ofconcept defines the requirements for a sender type that on successful completion sends the specified set of value types.Checklist