Config and structural updates to support unseq implementation #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akcube
requested review from
aurianer,
msimberg,
biddisco and
hkaiser
as code owners
|
Can one of the admins verify this patch? |
hkaiser
requested changes
Sep 21, 2022
|
|
||
| #pragma once | ||
|
|
||
| #include <hpx/config.hpp> |
There was a problem hiding this comment.
Why do you need this file? Wouldn't #including <hpx/config.hpp> instead of this file be sufficient?
| @@ -0,0 +1,22 @@ | |||
| set(tests "") | |||
There was a problem hiding this comment.
This file misses Copyright, License, and SPDX-License-Identifier. It also misses an endline on the last line.
| #define HPX_LANE_SIZE 64 | ||
| #endif | ||
|
|
||
| #endif |
| #define HPX_LANE_SIZE 16 | ||
| #else | ||
| #define HPX_LANE_SIZE 64 | ||
| #endif |
There was a problem hiding this comment.
I think the default should be no vectorization, e.g. if this is compiled on an ARM/SVE platform or similar. Alternatively, let's cause the compilation to fail (have an #error.
| #define HPX_LANE_SIZE 64 | ||
| #endif | ||
|
|
||
| #endif |
There was a problem hiding this comment.
All of your new files miss endline characters on the last lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Any background context you want to provide?
#2271