Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize iterator_support module #6063

Merged
merged 1 commit into from Nov 6, 2022
Merged

Modernize iterator_support module #6063

merged 1 commit into from Nov 6, 2022

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Nov 2, 2022

  • deprecate make_xxx functions, replace those with CTAD deduction guides

- deprecate make_xxx functions, replace those with CTAD deduction guides
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-11-03T13:07:54+00:00
HPX Commitd5655f85bf6313
Hostnamenid01193nid01059
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime2022-05-31T15:13:01.357969+02:002022-11-03T14:22:33.479136+01:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-11-03T13:07:54+00:00
HPX Commitd5655f85bf6313
Hostnamenid01193nid01059
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime2022-05-31T15:13:18.026239+02:002022-11-03T14:22:50.286060+01:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-11-03T13:07:54+00:00
HPX Commit71d8dbe5bf6313
Hostnamenid00120nid01059
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime2021-11-10T20:28:18.266961+01:002022-11-03T14:23:05.431796+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser
Copy link
Member Author

hkaiser commented Nov 6, 2022

bors merge

@bors
Copy link

bors bot commented Nov 6, 2022

Build succeeded:

  • Bors

@bors bors bot merged commit e622a91 into master Nov 6, 2022
@bors bors bot deleted the iterator_support branch November 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants