Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spatial_2d_padding operation #1018

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@taless474
Copy link
Contributor

commented Aug 6, 2019

This PR adds the spatial_2d_padding operation which imitates the functionality of Keras spatial_2d_padding.
The input is a 4d array which 2nd and 3rd dimensions are padded using this operation.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@taless474 please look at the codacy results. I think the warnings are genuine.

@taless474

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

You are right, that was a weird mistake.

@hkaiser
hkaiser approved these changes Aug 7, 2019
Copy link
Member

left a comment

LGTM, thanks a lot!

@taless474 taless474 force-pushed the spatial_2d_padding_operation branch from 122f9f2 to bea9d09 Aug 7, 2019

@taless474 taless474 force-pushed the spatial_2d_padding_operation branch from bea9d09 to 7bbb6b9 Aug 7, 2019

@hkaiser hkaiser merged commit 4a28c33 into master Aug 9, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
build_and_test_phylanx Workflow: build_and_test_phylanx
Details

@hkaiser hkaiser deleted the spatial_2d_padding_operation branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.