adding multiply primitive #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Sep 29, 2017
| std::vector<primitive> operands_; | ||
| }; | ||
| }}} | ||
|
|
There was a problem hiding this comment.
Something went wrong with the indentation here.
hkaiser
reviewed
Sep 29, 2017
| ); | ||
| } | ||
| }}} | ||
|
|
There was a problem hiding this comment.
Same here, indentation gone wrong
|
May I suggest you reformat all source files using clang-format (there is a .clang-format configuration file in the root of this repository). |
hkaiser
force-pushed
the
multiply_primitive
branch
from
667709d
to
0a8ee2f
Compare
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds multiply primitive. It works for vector of operands when:
issue: when tested with matrices larger than 100 by 100 got this:
Stack overflow in coroutine at address 0x00007f1286f2fbb8. Configure the hpx runtime to allocate a larger coroutine stack size. But the logic works and tests pass for smaller matrices.