Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Phylanx to build according to the pull request #3374 in HPX #519

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@NK-Nikunj
Copy link
Contributor

NK-Nikunj commented Jul 9, 2018

The pull request (STEllAR-GROUP/hpx#3371) propagates the linker flags and the option HPX_WITH_DYNAMIC_HPX_MAIN. So we do need to specifically add anything in this repository. It will be taken care of with variables specified in HPXConfig.cmake

EDIT:

Instead of reverting, this PR now changes Phylanx to build according to the pull request (STEllAR-GROUP/hpx#3374).
PhylanxSetupTarget will now contain add flags according to HPX_WITH_DYNAMIC_HPX_MAIN.

This PR should fix all the failing tests in Phylanx.

@NK-Nikunj NK-Nikunj force-pushed the NK-Nikunj:revert_to_original branch from 6d1caa5 to 03cefe2 Jul 9, 2018

@NK-Nikunj NK-Nikunj force-pushed the NK-Nikunj:revert_to_original branch from 03cefe2 to fe1b28a Jul 9, 2018

@NK-Nikunj NK-Nikunj changed the title Remove HPX_WITH_DYNAMIC_HPX_MAIN and linker flags Change Phylanx to build according to the pull request #3374 in HPX Jul 10, 2018

@hkaiser hkaiser merged commit b560548 into STEllAR-GROUP:master Jul 11, 2018

12 checks passed

ci/circleci: build_test Your tests passed on CircleCI!
Details
ci/circleci: check_code_format Your tests passed on CircleCI!
Details
ci/circleci: deploy_image Your tests passed on CircleCI!
Details
ci/circleci: tests.regressions Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.group_1 Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.group_2 Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.plugins.arithmetic Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.plugins.booleans Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.plugins.controls Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.plugins.fileio_solvers Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.plugins.listops Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.plugins.matrixops Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.