Safari extension

[b5i]

Hello, here is the Xcode project of the extension, tell me if I have to add the .app file (binaries).

[b5i]

Little problem with sources location, don't merge it now.

[rgantzos]

We’re an open source extension, and it costs a lot of money to publish Safari extensions. We will look into it.

[b5i]

We’re an open source extension, and it costs a lot of money to publish Safari extensions. We will look into it.

Of course, but people can install by double-clicking on an .app file and it installs automatically the extension (README file)

[b5i]

Ok now macOS is ready: just type make for macOS and make ios for iOS/iPadOS app.

[rgantzos]

When I test this with Xcode installed, none of the features are actually working. I'm going to do more tests.

[b5i]

When I test this with Xcode installed, none of the features are actually working. I'm going to do more tests.

It seems there is some problems with the scratch, I'm getting "Unexpected end of script" in main.js in the web console.

[rgantzos]

When I test this with Xcode installed, none of the features are actually working. I'm going to do more tests.

It seems there is some problems with the scratch, I'm getting "Unexpected end of script" in main.js in the web console

That's not the issue, you just have to pull the recent commits to your fork. That has already been fixed.

[b5i]

When I test this with Xcode installed, none of the features are actually working. I'm going to do more tests.

It seems there is some problems with the scratch, I'm getting "Unexpected end of script" in main.js in the web console

That's not the issue, you just have to pull the recent commits to your fork. That has already been fixed.

Done, but this time the extension works as it has to: (activated opacity button)

[mistysloth]

All the features work for me, but I'm not giving this a full approve because it doesn't work for everyone.

[rgantzos]

All the features work for me, but I'm not giving this a full approve because it doesn't work for everyone.

I could just be doing something wrong, but I’m going to have to be the one who explains it to everyone else so that means I should figure it out before merging.

[b5i]

All the features work for me, but I'm not giving this a full approve because it doesn't work for everyone.

I could just be doing something wrong, but I’m going to have to be the one who explains it to everyone else so that means I should figure it out before merging.

Ok so we need to figure out why it does not work in your case. When you say that it does not work, in which way?

[rgantzos]

All the features work for me, but I'm not giving this a full approve because it doesn't work for everyone.

I could just be doing something wrong, but I’m going to have to be the one who explains it to everyone else so that means I should figure it out before merging.

Ok so we need to figure out why it does not work in your case. When you say that it does not work, in which way?

It returns an error whenever I try and use `make`. Is the folder name important? I'm running the terminal in my folder.

[b5i]

Ok could you show before the help message from Xcode please?

[rgantzos]

Ok could you show before the help message from Xcode please?
…
Le 3 oct. 2022 à 18:14, rgantzos @.***> a écrit : All the features work for me, but I'm not giving this a full approve because it doesn't work for everyone. I could just be doing something wrong, but I’m going to have to be the one who explains it to everyone else so that means I should figure it out before merging. Ok so we need to figure out why it does not work in your case. When you say that it does not work, in which way? It returns an error whenever I try and use make. Is the folder name important? I'm running the terminal in my folder. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[b5i]

Ok I see, your directory contains a space and the make does not like it.

[rgantzos]

What does this do? (Your newest fix)

[b5i]

What does this do? (Your newest fix)

It assure that the path (even with a space) will be considered as one argument instead of two.

[rgantzos]

What does this do? (Your newest fix)

Oh, alright

What does this do? (Your newest fix)

It assure that the path (even with a space) will be considered as one argument instead of two.

Oh alright thanks, I’ll check it out soon. We’re planning on releasing this for our big 1,000 user event, but this will likely be merged before then.