Coloring errors

[Razican]

We currently have some coloring errors in the console, this should be fixed for the next version (or hopefully, if it's really easy to fix, for 0.1.0.

An example:

[pocket7878]

Is there any minimum example to reproduce this error?

[Br1oP]

Hello, @pocket7878. I just made a simple example to reproduce the error. This is the code:

extern crate colored;

use colored::*;

fn main() {
    let world = "world".bold();
    let hello_world = format!("Hello, {}!", world);
    println!("{}", hello_world);
    let hello_world = format!("Hello, {}!lalalala", world).red();
    println!("{}", hello_world);
}

These are the results:

As you see, when you mix bold + colour, the colouring is not working correctly. It should colour the whole sentence but it stops at the exclamation mark.

[Razican]

I reported the issue in upstream.

It might be solved using termion (tutorial), since it seems an upstream issue. If not, we might need to modify our printing system, maybe creating our own printing library.

[mackwic]

Thanks for the bug report. Please update to colored 1.3.1 which fixes the problem as the tests, and the example show (you can run cargo run --example=nested_colors to see @Br1oP's example passing).

If you have any issue or suggestion to make colored better, don't hesitate to submit an issue. Have a great day

Ref PR: colored-rs/colored#12

[Br1oP]

Cool, it works great now!

I'm closing this issue, thx.

[Razican]

This has been reopened in upstream, seems that we still have the problem: colored/#11