From bcc343c91f93bab319d9414187b272361511a4a8 Mon Sep 17 00:00:00 2001 From: Martin Grzeslowski Date: Tue, 9 Apr 2019 23:09:05 +0200 Subject: [PATCH] #9 Turn off LED when `brightness` is zero --- .../openhab/binding/supla/handler/CloudDeviceHandler.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/addons/binding/org.openhab.binding.supla/src/main/java/org/openhab/binding/supla/handler/CloudDeviceHandler.java b/addons/binding/org.openhab.binding.supla/src/main/java/org/openhab/binding/supla/handler/CloudDeviceHandler.java index 36b0141decb5..27cb97097baf 100644 --- a/addons/binding/org.openhab.binding.supla/src/main/java/org/openhab/binding/supla/handler/CloudDeviceHandler.java +++ b/addons/binding/org.openhab.binding.supla/src/main/java/org/openhab/binding/supla/handler/CloudDeviceHandler.java @@ -280,8 +280,14 @@ protected void handlePercentCommand(final ChannelUID channelUID, final PercentTy private void sendNewLedValue(final ChannelUID channelUID, int channelId, final HSBType hsbType) throws ApiException { final String rgb = HsbTypeConverter.INSTANCE.convert(hsbType); - final int colorBrightness = hsbType.getSaturation().intValue(); final int brightness = hsbType.getBrightness().intValue(); + final int colorBrightness; + if (brightness > 0) { + colorBrightness = hsbType.getSaturation().intValue(); + } else { + logger.trace("Set colorBrightness to 0% because brightness is 0%"); + colorBrightness = 0; + } logger.trace("Changing RGB to {}, color brightness {}%, brightness {}%", rgb, colorBrightness, brightness); final ChannelExecuteActionRequest action = new ChannelExecuteActionRequest() .action(SET_RGBW_PARAMETERS)