Implement revoking a share by the sender for OCM group share

[navid-shokri]

No description provided.

[navid-shokri]

in user-to-user federated sharing when the sender (einstein) revokes the share (clicking on the trash bin icon) shared file will be removed from the receiver's (marine) file list.

but in user-to-group sharing when einstein revokes the sharing, the shared file is accessible to Marie.

[navid-shokri]

revoke share invoke this stack of methods:

https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/apps/files_sharing/lib/Controller/Share20OcsController.php#L333

https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/lib/private/Share20/Manager.php#L1166

at this line:
https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/lib/private/Share20/Manager.php#L1184

the provider type is OCA\FederatedFileSharing\FederatedShareProvider

this is the Line that indicates which type should be returned:

rd-sram-integration/federatedgroups/lib/ShareProviderFactory.php

Line 126 in 3ec270e

public function getProviderForType($shareType) {

[navid-shokri]

after debuging I found that we are setting share_type to 6 (SHARE_TYPE_REMOTE) while it should be 7 (SHARE_TYPE_REMOTE_GROUP) .

so, I created another issue #87 to resolve this problem and after that I will continue this thread.

[michielbdejong]

@yasharpm you said that a unit test exists for this, but I can't find it, is it in https://github.com/pondersource/oc-opencloudmesh/blob/main/opencloudmesh/tests/Controller/OcmControllerTest.php somewhere?