New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dashboard: Ceph - Cluster #853
Improve Dashboard: Ceph - Cluster #853
Conversation
- consistently apply template variable filtering {cluster='$cluster',instance='$instance',job='ceph-exporter'} to: Pools, Average PGs per OSD, Average OSD Apply Latency, Average OSD Commit Latency, Objects in the Cluster, PGs, Stuck PGs, Recovery, Bytes, Keys, Objects - Show header of "Recovery" row - Dont display interpolated graphs on null values so that missing values in outage situations are visible - Graph style: fill=0, line=1, point=1; stacked graph style: fill=1 - IOPs not stacked - Throughput not stacked - Capacity min y = 0 to make usage level obvious Signed-off-by: Marc Aßmann <marc.assmann@sap.com>
Can one of the admins verify this patch? |
Hi Marc, thanks a lot for your various enhancement requests for the Grafana dashboards - much appreciated! Would it be possible for you to attach some sample screen shots of the new widgets to your PRs? That makes it somewhat easier to review your suggested changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new file is malformed. If you export the dashboard via Grafana as JSON file you can't simply replace it with the file in this repository. You need to modify it manually instead:
Modify the exported JSON file first:
- Remove the
__inputs
object - Replace all occurances of ${DS_PROMETHEUS}: s/${DS_PROMETHEUS}/Prometheus/
Now insert the Grafana export into the GIT file:
{
"overwrite": true,
"dashboard": {
<-- INSERT HERE THE CODE FROM THE GRAFANA JSON EXPORT FILE -->
}
}
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
- Removed the __inputs object - Replaced all occurances of ${DS_PROMETHEUS}: s/${DS_PROMETHEUS}/Prometheus/ - Wrapped the dashboard JSON so it can be used as Grafana API request Signed-off-by: Marc Aßmann <marc.assmann@sap.com>
WARNING. This PR is not tested with teuthology, please run the tests again if required. |
Stale/Inactive - Please re-open if needed |
{cluster='$cluster',instance='$instance',job='ceph-exporter'} to: Pools,
Average PGs per OSD, Average OSD Apply Latency, Average OSD Commit
Latency, Objects in the Cluster, PGs, Stuck PGs, Recovery, Bytes, Keys,
Objects
in outage situations are visible
Signed-off-by: Marc Aßmann marc.assmann@sap.com