environments: do not migrate by default

The migration part is now expected to be done by the administrator. This is done automatically by the init script in containerized deployments. This was done because now we had at least two portus processes accessing the DB and trying to migrate the DB, which caused quite some issues. Moreover, notice that the previous workflow (e.g. automatically migrating on production) was simply not possible in orchestration solutions like Docker Swarm or Kubernetes. Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
SUSE · Jan 12, 2018 · 1c4d2b6cf0e09e3be770a0675a42ee23cd2f62dd · 1c4d2b6
1 parent 5e1932c
commit 1c4d2b6cf0e09e3be770a0675a42ee23cd2f62dd
Unified Split

Showing with 1 addition and 21 deletions.

+0 −14 config/environments/helpers/migrate.rb

+0 −4 config/environments/production.rb

+1 −2 packaging/suse/portus.spec.in

+0 −1 packaging/suse/portusctl/lib/configurator.rb
diff --git a/config/environments/helpers/migrate.rb b/config/environments/helpers/migrate.rb
diff --git a/config/environments/production.rb b/config/environments/production.rb
@@ -84,8 +84,4 @@

  # Do not dump schema after migrations.
  config.active_record.dump_schema_after_migration = false
-
-  # Run pending migrations
-  require_relative "helpers/migrate"
-  run_migration!(config)
 end
diff --git a/packaging/suse/portus.spec.in b/packaging/suse/portus.spec.in
@@ -95,8 +95,7 @@ bundle install --retry=3 --local --deployment --without assets test development
 gem.ruby2.4 install --no-rdoc --no-ri --install-dir vendor/bundle/ruby/%{rb_ver}/ vendor/cache/bundler-*.gem

 # Compile assets
-SKIP_MIGRATION="yes" \
-  PORTUS_SECRET_KEY_BASE="ap" PORTUS_KEY_PATH="ap" PORTUS_PASSWORD="ap" \
+PORTUS_SECRET_KEY_BASE="ap" PORTUS_KEY_PATH="ap" PORTUS_PASSWORD="ap" \
  RAILS_ENV=production NODE_ENV=production \
  bundle exec rake portus:assets:compile

diff --git a/packaging/suse/portusctl/lib/configurator.rb b/packaging/suse/portusctl/lib/configurator.rb
@@ -116,7 +116,6 @@ def create_database
    Runner.activate_service("mysql") if database_local?

    env_variables = {
-      "SKIP_MIGRATION"  => "yes",
      "PORTUS_PASSWORD" => @portus_password
    }
    puts "Creating Portus' database"