New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request : Add a parameter for catalog page size #1001

Closed
Seb-Solon opened this Issue Jul 20, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@Seb-Solon

Seb-Solon commented Jul 20, 2016

Hi!

Due to docker/distribution#1854 I had to manually edit the request page size here : https://github.com/SUSE/Portus/blob/master/lib/portus/registry_client.rb#L97
Do you think it is a good to make it configurable for the user? In my case it would be a better workaround for my issue. I am afraid that you may have some issue created in this repo regarding missing repositories/image in the web interface due to this registry bug. This could be a workaround while the registry is fixed.

Regards,

@mssola

This comment has been minimized.

Show comment
Hide comment
@mssola

mssola Jul 20, 2016

Contributor

Sounds good to me 👍. We are already providing a configurable value like jwt_expiration_time which is pretty "internal" anyways.

Contributor

mssola commented Jul 20, 2016

Sounds good to me 👍. We are already providing a configurable value like jwt_expiration_time which is pretty "internal" anyways.

@mssola mssola added the feature label Jul 20, 2016

@mssola

This comment has been minimized.

Show comment
Hide comment
@mssola

mssola Jul 20, 2016

Contributor

That being said, development for this will start once the bug is confirmed in distribution 😉

Contributor

mssola commented Jul 20, 2016

That being said, development for this will start once the bug is confirmed in distribution 😉

mssola added a commit to mssola/Portus that referenced this issue Jul 21, 2016

Added the registry.catalog_page option
With this option we will be able to workaround docker/distribution#1854.
Moreover, with this we will allow administrators to further tweak how Portus
interacts with the registry.

Moreover, because of this new addition, I felt like groupping registry-related
configurable options would be a good idea, so now all these options are under
the new `registry` section. We are still providing a compatibility layer in the
Portus::Migrate module.

Fixes #1001

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@mssola

This comment has been minimized.

Show comment
Hide comment
@mssola

mssola Jul 21, 2016

Contributor

@Seb-Solon done! I'm adding the registry.catalog_page configurable value for this (see PR #1002).

Contributor

mssola commented Jul 21, 2016

@Seb-Solon done! I'm adding the registry.catalog_page configurable value for this (see PR #1002).

mssola added a commit to mssola/Portus that referenced this issue Jul 21, 2016

Added the registry.catalog_page option
With this option we will be able to workaround docker/distribution#1854.
Moreover, with this we will allow administrators to further tweak how Portus
interacts with the registry.

Moreover, because of this new addition, I felt like groupping registry-related
configurable options would be a good idea, so now all these options are under
the new `registry` section. We are still providing a compatibility layer in the
Portus::Migrate module.

Fixes #1001

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@Seb-Solon

This comment has been minimized.

Show comment
Hide comment
@Seb-Solon

Seb-Solon commented Jul 21, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment