From b87f4efb5689a8db77e06baf4f469afcd9df3677 Mon Sep 17 00:00:00 2001 From: Nathan Cutler Date: Fri, 26 Feb 2016 18:30:49 +0100 Subject: [PATCH] packaging: lsb_release build and runtime dependency The lsb_release executable is being run in multiple places, not least in src/common/util.cc, which calls it via shell in the collect_sys_info() code path. This patch addresses this issue on SUSE- and Debian-derivatives, as well as reinstating the dependency for RHEL/Fedora after it was dropped in 15600572265bed397fbd80bdd2b7d83a0e9bd918. http://tracker.ceph.com/issues/14906 Fixes: #14906 Signed-off-by: Nathan Cutler --- ceph.spec.in | 11 ++++++++++- debian/control | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ceph.spec.in b/ceph.spec.in index d3e9cc0bd84af..a8f89186b328b 100644 --- a/ceph.spec.in +++ b/ceph.spec.in @@ -158,7 +158,9 @@ BuildRequires: gperftools-devel BuildRequires: mozilla-nss-devel BuildRequires: keyutils-devel BuildRequires: libatomic-ops-devel -%else +BuildRequires: lsb-release +%endif +%if 0%{?fedora} || 0%{?rhel} %if 0%{?_with_systemd} Requires: systemd %endif @@ -169,6 +171,7 @@ Requires(post): chkconfig Requires(preun): chkconfig Requires(preun): initscripts BuildRequires: gperftools-devel +BuildRequires: redhat-lsb-core %endif # boost %if 0%{?fedora} || 0%{?rhel} @@ -236,6 +239,12 @@ Requires: hdparm Requires: cryptsetup Requires: findutils Requires: which +%if 0%{?suse_version} +Requires: lsb-release +%endif +%if 0%{?fedora} || 0%{?rhel} +Requires: redhat-lsb-core +%endif %description base Base is the package that includes all the files shared amongst ceph servers diff --git a/debian/control b/debian/control index d4d31469db170..1d37d916cc915 100644 --- a/debian/control +++ b/debian/control @@ -84,6 +84,7 @@ Depends: binutils, gdisk, grep, logrotate, + lsb-release, parted, python, python-argparse,