Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document 1.16.0 k8s #606

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Document 1.16.0 k8s #606

merged 5 commits into from
Dec 3, 2019

Conversation

nkoranova
Copy link
Contributor

@nkoranova nkoranova added On-Hold PR needs work and should not be merged even if reviews are complete v4.1 labels Nov 20, 2019
@nkoranova nkoranova self-assigned this Nov 20, 2019
@r0ckarong r0ckarong added 4.1.0 and removed v4.1 labels Nov 26, 2019
evrardjp
evrardjp reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably have other attributes to change here. Let's do this when SUSE/caasp-release-notes#18 is ready ?

@nkoranova
Copy link
Contributor Author

We probably have other attributes to change here. Let's do this when SUSE/caasp-release-notes#18 is ready ?

Don't worry about that for now, there will be enough time to do that.

@nkoranova
Copy link
Contributor Author

I've synced the changes in the attributes file with the RN attributes for now.

evrardjp
evrardjp reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@evrardjp evrardjp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it could be confusing to point to old numbers? Should we update those numbers to 1.16.2?

adoc/admin-updates.adoc Show resolved Hide resolved
@nkoranova nkoranova mentioned this pull request Dec 3, 2019
Closed
@nkoranova nkoranova merged commit 3bfd760 into master Dec 3, 2019
@r0ckarong r0ckarong removed the On-Hold PR needs work and should not be merged even if reviews are complete label Jan 13, 2020
@r0ckarong r0ckarong deleted the kubernetes_1.16 branch April 22, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre left review comments

@evrardjp evrardjp evrardjp left review comments

Assignees

@nkoranova nkoranova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkoranova @ereslibre @evrardjp @r0ckarong