This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Virtualization: mention the minimum salt version #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loquacity
approved these changes
May 13, 2019
jcayouette
suggested changes
May 13, 2019
There was a problem hiding this comment.
@cbosdo Please adjust the hardcoded salt version to {saltversion} or later.
This way it will automatically update based on our the entity defined in our suma and uyuni playbooks..
|
@jcayouette no: this is a minimum required version: it shouldn't change in the future, while the macro will change for sure. |
Ah right, thanks for clarifying then leave as is 👍 |
jcayouette
approved these changes
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell that the virtualization features will only work if the salt minion has 2019.2.0+ salt