From 7aebf097c6d8f658d58967724b1fbeb6f1ae4403 Mon Sep 17 00:00:00 2001 From: Thomas Muntaner Date: Mon, 23 Apr 2018 14:56:48 +0200 Subject: [PATCH] Properly test against disabling recommended extensions --- spec/factories/products.rb | 8 ++++++++ spec/lib/rmt/cli/products_spec.rb | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/spec/factories/products.rb b/spec/factories/products.rb index 8af01451f..3234cdf02 100644 --- a/spec/factories/products.rb +++ b/spec/factories/products.rb @@ -69,6 +69,14 @@ end end + trait :with_enabled_recommended_extensions do + after :create do |product, _evaluator| + 5.times do + create(:product, :extension, :with_mirrored_repositories, base_products: [product], recommended: true) + end + end + end + trait :with_modules do after :create do |product, _evaluator| 5.times do diff --git a/spec/lib/rmt/cli/products_spec.rb b/spec/lib/rmt/cli/products_spec.rb index d7c2ab28e..58ae5bf13 100644 --- a/spec/lib/rmt/cli/products_spec.rb +++ b/spec/lib/rmt/cli/products_spec.rb @@ -200,7 +200,7 @@ end context 'with recommended extensions' do - let(:product) { create :product, :with_mirrored_repositories, :with_recommended_extensions } + let(:product) { create :product, :with_mirrored_repositories, :with_enabled_recommended_extensions } let(:extensions) { Product.recommended_extensions(product).to_a } it 'does not disable extension repositories' do @@ -209,7 +209,7 @@ end extensions.each do |extension| extension.repositories.each do |repository| - expect(repository.mirroring_enabled).to eq(false) + expect(repository.mirroring_enabled).to eq(true) end end end