Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 3.2-NUE, add 4.2 #277

Merged
merged 2 commits into from May 10, 2021
Merged

Remove 3.2-NUE, add 4.2 #277

merged 2 commits into from May 10, 2021

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented May 7, 2021 •
edited

Git detected the removal of 3.2-NUE and creation of 4.2-NUE as a replacement, so better ignore the diff, and review the whole file.

Requires https://gitlab.suse.de/galaxy/infrastructure/-/merge_requests/338

ktsamis
ktsamis reviewed May 10, 2021
View reviewed changes
Copy link
Member

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, thank you Julio. Just not sure about the additional_repo with the java update.

terracumber_config/tf_files/SUSEManager-4.2-PRV.tf Outdated Show resolved Hide resolved
@juliogonzalez
Copy link
Member Author

BTW, this testsuite is missing something else. The pipeline definitions!

I will handle it in a few minutes.

ktsamis
ktsamis requested changes May 10, 2021
View reviewed changes
Copy link
Member

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we want to go with the default branch for now, I would say let's have first runs against master and then when we create the branch we switch them. Otherwise looks great

jenkins_pipelines/environments/manager-4.2-dev-acceptance-tests-PRV Outdated Show resolved Hide resolved
jenkins_pipelines/environments/manager-4.2-dev-acceptance-tests-NUE Show resolved Hide resolved
jenkins_pipelines/environments/manager-4.2-dev-acceptance-tests-PRV Show resolved Hide resolved
@juliogonzalez
Copy link
Member Author

fault branch for now, I

Not sure how we want to go with the default branch for now, I would say let's have first runs against master and then when we create the branch we switch them. Otherwise looks great

The jobs will be disabled until we branch. For now the D:G:M:4.2 is not usable, as it does not contain all packages, and we'll only have everything there when we branch.

ktsamis
ktsamis approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Since they will be disabled anyway, I would like to let others take a look as well if they catch something but from me, 👍 Let's just wait a few hours before merging

srbarrios
srbarrios requested changes May 10, 2021
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review all the MAC addresses before merging this PR, please.
It doesn't seem to match with https://gitlab.suse.de/galaxy/infrastructure/-/merge_requests/338

srbarrios
srbarrios approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I mixed. Changes for NUE were made in a different PR https://gitlab.suse.de/galaxy/infrastructure/-/merge_requests/337

srbarrios
srbarrios requested changes May 10, 2021
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm but in any case, it seems 4.2 reference MACs are wrong

@juliogonzalez juliogonzalez merged commit 5cd0238 into SUSE:master May 10, 2021
@juliogonzalez juliogonzalez deleted the SUSE-Manager-4.2 branch May 10, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srbarrios srbarrios srbarrios approved these changes

@ktsamis ktsamis ktsamis approved these changes

@0rnela 0rnela Awaiting requested review from 0rnela

@atighineanu atighineanu Awaiting requested review from atighineanu

@Bischoff Bischoff Awaiting requested review from Bischoff

@lkotek lkotek Awaiting requested review from lkotek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliogonzalez @srbarrios @ktsamis