Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add Lumberjack Logging Framework #82

Merged
merged 3 commits into from Jun 5, 2013

Conversation

Projects
None yet
4 participants
Contributor

dblandin commented May 13, 2013

No description provided.

Contributor

dblandin commented May 13, 2013

There are a few features missing from this pull request at the moment:

  • Allow the client to specify which log level SVGKit should use internally

Something like:

[SVGKit enableLogging: SVG_LOG_LEVEL_VERBOSE];

Right now, the log level is set to verbose for DEBUG builds, and warn for all other builds.

  • Use a custom context for SVGLogWarn-style (instead of the default DDLogWarn) syntax.

The ddLogLevel constant is currently defined at compile time. I'm not sure of the best way to make this a dynamic option set by the client app and globally available in SVGKit.

Any thoughts?

Contributor

adamgit commented May 15, 2013

Is it possible to include as a binary instead of source code? (I don't know if that's allowed from the license). Including full source can cause problems later if you try to integrate with other projects that also include the full source (I'm not 100% sure why this happens, seems to be something odd in houw Xcode links sub-projects).

Github won't auto-merge this, so I'll have to come back later and merge by hand, but otherwise looks fine.

Contributor

dblandin commented May 15, 2013

Looks likes redistribution in binary form is allowed.

I'll see if I can convert the source code to a universal binary and use that instead.

Contributor

adamgit commented May 15, 2013

Assuming this works, of course :). I'm only trying to find whatever is the
easiest, most robust way of shipping the lib. If source-code is the only
way to do that, we should do it that way.

(might be we just have to include the source, but make sure we don't
accidentally export any of the symbols?)

On 15 May 2013 17:40, Devon Blandin notifications@github.com wrote:

Looks likes redistribution in binary form is allowed.

I'll see if I can convert the source code to a universal binary and use
that instead.


Reply to this email directly or view it on GitHubhttps://github.com/SVGKit/SVGKit/pull/82#issuecomment-17950569
.

Contributor

dblandin commented Jun 4, 2013

I wasn't able to find a way to include Lumberjack as a binary without losing the ability to adjust the LogLevel (which takes place during compilation).

Right now, the LogLevel is set here:
https://github.com/dblandin/SVGKit/commit/838496a160cd8693bc17325866ecf9f647406779#L0R10

Contributor

adamgit commented Jun 5, 2013

I haven't had time to review recently, sorry - very busy in day job. When I get time soon, I'll review all the outstanding requests and try to get them all merged + tested in a single batch.

(if anyone wants to help, you can take the "1.1.0" branch, merge the change requests LOCALLY, run the Demo app and test that every image is working fine, then contact me and let me know. We work on the basis "get a 2nd person to check the code before we merge it")

@adamgit adamgit merged commit 838496a into SVGKit:1.1.0 Jun 5, 2013

dgileadi pushed a commit to dgileadi/SVGKit that referenced this pull request Nov 1, 2013

markst commented Jul 10, 2015

If I have CocoaLumberjack as part of my project as well as SVGKit, then the global variable ddLogLevel causes conflicts.

Contributor

seltzered commented Jul 10, 2015

Hey @markst is this occurring on the latest 2.x branch? Are you installing svgkit via cocoapods or something else?

What version of CocoaLumberjack are you using in your own project? In svgkit 2.x I updated things a few months ago to use CL 2.0 (see #251 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment