Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To make Objective-C's enum easier to use even for swift #937

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@keisukeYamagishi
Copy link

commented Nov 24, 2018

I made enum written for Obejctive-C available with Swift style enum.

It became easier to use when using with swift.

@juliensaad

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

This looks good, but will probably break compatibility with Swift users currently using it. I'd lean towards merging as the conventions are respected here.

What are your thoughts @honkmaster ?

@keisukeYamagishi

This comment has been minimized.

Copy link
Author

commented Dec 1, 2018

Does it affect swift users?
Rather, I could declare it explicitly, I felt good and created a PR.

If you are concerned, you should close it.

@honkmaster

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

To be honest: I don't have a dedicated opinion on this because I don't use the component with Swift.

@juliensaad

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

Same here ~ I would go ahead and merge since this is more standard.

@juliensaad juliensaad merged commit e2a6aaa into SVProgressHUD:master Dec 1, 2018

@keisukeYamagishi keisukeYamagishi deleted the keisukeYamagishi:add_swift_enum branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.