Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul target editor #176

Merged
merged 174 commits into from Feb 11, 2020
Merged

Overhaul target editor #176

merged 174 commits into from Feb 11, 2020

Conversation

@mahesh-krishnakumar
Copy link
Member

mahesh-krishnakumar commented Jan 17, 2020

Have separate tabs to manage content, configurations and content versions

Tackles issues:

  • #6: This is a complete overhaul of the entire component chain.
  • #55: Besides having no dedicated preview state, the new content editor will detect every kind of change that is yet to be saved and alert before closing the editor panel, or changing the editor's tab. This applies for the target details tab as well.
  • #56: There's a new markdown editor included with this PR, and it uses a plain text-area as its input field, so styled-content pasting isn't an issue.
  • #80: The new content editor only works on the current version of the target and never creates a new version - this side-steps the issue entirely. Handling of versions is now done in a dedicated new interface.
  • #101: This is done on the new implementation.
  • #183: The new markdown editor is almost entirely custom code that is built around a simple textarea, and is a candidate for extraction as a library.

Post merge

  • Update real world example link and github link multiselect-inline package documentation, to master.
  • Drop content_versions table
harigopal and others added 24 commits Jan 13, 2020
@mahesh-krishnakumar

This comment has been minimized.

Copy link
Member Author

mahesh-krishnakumar commented Jan 17, 2020

Target details editor

app/controllers/schools/content_blocks_controller.rb Outdated Show resolved Hide resolved
app/controllers/schools/content_blocks_controller.rb Outdated Show resolved Hide resolved
app/javascript/shared/utils/GraphqlQuery.re Outdated Show resolved Hide resolved
app/models/content_block.rb Outdated Show resolved Hide resolved
app/policies/schools/target_policy.rb Outdated Show resolved Hide resolved
mahesh-krishnakumar and others added 6 commits Feb 10, 2020
 - @pupilfirst/multiselect-inline@1.1.0
Publish
 - @pupilfirst/multiselect-inline@1.1.1
app/javascript/packages/multiselect-inline/README.md Outdated Show resolved Hide resolved
app/queries/update_target_mutator.rb Show resolved Hide resolved
app/queries/update_target_mutator.rb Show resolved Hide resolved
app/queries/update_target_mutator.rb Outdated Show resolved Hide resolved
app/services/targets/update_service.rb Show resolved Hide resolved
@harigopal harigopal merged commit ee37f02 into master Feb 11, 2020
1 check failed
1 check failed
continuous-integration (PupilFirst) TeamCity build failed
Details
@bodhish bodhish temporarily deployed to sv-co Feb 11, 2020 Inactive
@harigopal harigopal deleted the overhaul-target-editor branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.