Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a target completion/evaluation checklist for students and coaches #205

Merged
merged 163 commits into from Mar 2, 2020

Conversation

@mahesh-krishnakumar
Copy link
Member

mahesh-krishnakumar commented Feb 13, 2020

Checklist

  • Write documentation and add a help icon on the target checklist editor
  • Set sanity limit for target checklist (15)
  • Target title should be trimmed on save.
  • Show quiz answers as separate items that have correct / incorrect states marked.
  • #136

After merge

  • Remove fields description and links from timeline event

A target that is reviewed by a coach will now have a checklist, which is a series of steps that a student needs to do as part of completing the target and submitting it. Each step can have an action (like short text, long text, file attachment, etc. ) or no action. Each step in the checklist can be optional as well. The target checklist will be stored as a jsonb field (Target#checklist) with the following shape:

 [  
    {  
      "title": "Upload a file for this task",  
      "optional": "false",  
      "kind": "files"  
    },  
     {  
      "title": "Add a short text about the submission",  
      "optional": "true",  
      "kind": "short_text"  
    },  
        {  
      "title": "Add a long text describing the task",  
      "optional": "false",  
      "kind": "long_text"  
    }  
  ]  
}

The student performs each of these steps using the submission interface and on submission, the response will be stored in a jsonb field TimelineEvent#checklist. An example checklist response :

{  
  [  
    {  
      "title": "Upload a file for this task",  
      "answer": "Link to file",  
      "kind": "upload_file", 
      "review": nil,
    },  
     {  
      "title": "Add a short text about the submission",  
      "answer": "The short text by the student",  
      "kind": "short_text",
      "review": nil,  
    },  
        {  
      "title": "Add a long text describing the task",  
      "result": ""   
      "kind": "long_text",
      "status": "verified" / "failed" / "pending" ,  
    }  
  ]  
}

The valid types for kind: ["files", "link", "long_text", "multi_choice", "short_text"]

The coach in his/her review interface will verify a submission against each of these steps in the checklist. Based on the response from the coach the review field for each checklist item will be updated to nil/true/false

  • Target reviewed by a coach must have a checklist. The UI should create a default checklist will the most basic steps for any target (maybe long_text + links + attach links).
mahesh-krishnakumar and others added 22 commits Feb 13, 2020
…CO/pupilfirst into issues/29/target-checklist
@vinutv

This comment has been minimized.

Copy link
Contributor

vinutv commented Feb 17, 2020

Submission-overlay-coach-target-completion-evaluation-checklist
Submission Overlay - Coach

vinutv and others added 22 commits Feb 27, 2020
…CO/pupilfirst into issues/29/target-checklist
…CO/pupilfirst into issues/29/target-checklist
@mahesh-krishnakumar mahesh-krishnakumar merged commit fd72051 into master Mar 2, 2020
1 check passed
1 check passed
continuous-integration (PupilFirst) TeamCity build finished
Details
@mahesh-krishnakumar mahesh-krishnakumar temporarily deployed to sv-co Mar 2, 2020 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.