New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/insert on edge #583

Merged
merged 3 commits into from May 4, 2016

Conversation

Projects
None yet
2 participants
@arpith20
Contributor

arpith20 commented Apr 29, 2016

insertOnEdge(toInsert, source, target) adds instrumentation in a manner such that the resulting CFG of the program will contain toInsert on an edge that is defined by source and target.

@StevenArzt

This comment has been minimized.

Member

StevenArzt commented Apr 29, 2016

The code change seems reasonable. However, please add Javadoc comments for your new methods. Otherwise, it's really hard for the user to understand what they do.

Btw, I appreciate the comments inside the method. They are really good.

@arpith20

This comment has been minimized.

Contributor

arpith20 commented May 3, 2016

@StevenArzt Thank you for your feedback. I added Javadoc comments to the methods.

@StevenArzt StevenArzt merged commit 81ddd74 into Sable:develop May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment