Initial ISO Protection Detection #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Initial PR is ready for review. There's no rush, especially since Serialization isn't bumped yet anyways. If you see me making additional commits, that does not mean the PR is not ready for review, it just means I'm tweaking edge cases based on some random additional discs that get scanned. |
Collaborator
|
Serialization has been updated. Rebase when you can. |
mnadareski
reviewed
Nov 6, 2025
mnadareski
reviewed
Nov 6, 2025
mnadareski
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a draft PR for showcase purposes, will be un-drafted once all protections are added (and Serialization is bumped, but that will most likely happen first).
I know it should return
nullinstead of "None", the "None" is just there for testing reasons atm.