New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly filter invalid GPS/CPM lines from bgeigie file #495

Open
matschaffer opened this Issue Sep 7, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@matschaffer
Member

matschaffer commented Sep 7, 2018

Looks like from https://github.com/Safecast/safecastapi/blob/master/app/models/bgeigie_import.rb#L173-L177 that we're accepting measurements which have both A and V for the GPS CPM lines, but doesn't look like we're capturing it at all.

@matschaffer

This comment has been minimized.

Show comment
Hide comment
@matschaffer

matschaffer Sep 7, 2018

Member

/cc @jamoross who brought this up
/cc @robouden who might be able to comment on the bgeigie file format and expectation

Member

matschaffer commented Sep 7, 2018

/cc @jamoross who brought this up
/cc @robouden who might be able to comment on the bgeigie file format and expectation

@matschaffer

This comment has been minimized.

Show comment
Hide comment
@matschaffer

matschaffer Sep 7, 2018

Member

Once we sort this out we can probably restructure this ticket to include capturing this column(s) for future uploads.

Member

matschaffer commented Sep 7, 2018

Once we sort this out we can probably restructure this ticket to include capturing this column(s) for future uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment