Fix undefined method in device stories page #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitoball
force-pushed
the
fix-undefined-method-in-device_stories-page
branch
2 times, most recently
from
5f40c84
to
96abf73
Compare
matschaffer
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Thanks for the fix!
One thing this has me thinking is maybe we should get some testing around this that involves the elasticsearch container.
Since we're just passing in json, we could hit issues on our next elasticsearch upgrade and miss it in the test suite.
Anyway, I think this PR is great as is and unblocks master. So let's merge it.
@matschaffer How do we merge branch lately? "Rebase and merge" ? |
|
I’m fine with anything really. I usually squash and merge since it makes revert easy. |
eitoball
force-pushed
the
fix-undefined-method-in-device_stories-page
branch
from
96abf73
to
b0a918a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed to dev.safecast.org.