Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross Manifest Validation: Value Level Comparisons and Reworked Warning Messages #751

Merged
merged 42 commits into from
Jul 13, 2022
Merged

Cross Manifest Validation: Value Level Comparisons and Reworked Warning Messages #751

merged 42 commits into from
Jul 13, 2022

Conversation

GiaJordan
Copy link
Contributor

No description provided.

@GiaJordan
new rule arg: set/value
b3368d4
@GiaJordan
update parsing for new arg
28c3adf
@GiaJordan
WIP update error gen input for cross manifest
b3aa53e
@GiaJordan
WIP updated dummy data
2b7cb7e
@GiaJordan
WIP logic for manifest merges, no new errors yet
f4431ff
@GiaJordan
add new attributes to component
a7e4d94
@GiaJordan
WIP cleaning
57c3530
@GiaJordan
switch cross manifest component for tests
954084d
@GiaJordan
WIP temp fix for new rule error
78294bc
@GiaJordan
Revert "WIP temp fix for new rule error"
988eab3 
This reverts commit 78294bc.
@GiaJordan
WIP do not generate errors for new rules
82c8b57
@GiaJordan
switch rule arg order
8953ef0
@GiaJordan
WIP concat instead of merge
b91c2f4
@GiaJordan
WIP separate logic for sets and values
3256c06
@GiaJordan
less verbose cross manifest errors, updated tests
cbc8c1e
@GiaJordan
WIP Error formatting update
462d909
@GiaJordan
WIP error gen for at least one match
6e7db3b
@GiaJordan
example model rule change
5b8e095
@GiaJordan
update dummy data
2142ee2
@GiaJordan
error gen arg change
048feda
@GiaJordan
WIP add error gen for match exactly values
46e89c3
@GiaJordan
WIP test debug
2e5aca1
@GiaJordan
Update test data
2f97246
@GiaJordan
tests for new rules
cca178e
@GiaJordan
Update validate_attribute.py
5f700bf
@GiaJordan
update to include missing and duplicated values for exactly matching
d09632c
@GiaJordan
Merge branch 'develop' into develop-crossM-union-rule
15da9c0
@GiaJordan
Merge branch 'develop' into develop-crossM-union-rule
a59a356
@GiaJordan
Merge branch 'develop' into develop-crossM-union-rule
2d3efd6
@GiaJordan
fix row numbers for error msg
b714c77
This was linked to issues May 24, 2022
New Validation Rule: Cross Manifest Validation - Union #719
Closed
Improve the error handling on cross-validation rule #683
Closed
@GiaJordan GiaJordan marked this pull request as draft May 26, 2022 21:45
@GiaJordan GiaJordan marked this pull request as ready for review June 21, 2022 16:23
@GiaJordan GiaJordan mentioned this pull request Jun 21, 2022
Closed
4 tasks
@milen-sage milen-sage mentioned this pull request Jul 8, 2022
Merged
@milen-sage milen-sage merged commit bb7fe50 into develop Jul 13, 2022
@GiaJordan GiaJordan deleted the develop-crossM-union-rule branch July 18, 2022 17:31
@GiaJordan
Copy link
Contributor Author

@milen-sage @ychae updated documentation on cross manifest rule argument specification

@linglp linglp mentioned this pull request Aug 24, 2022
Merged
@GiaJordan GiaJordan mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milen-sage milen-sage milen-sage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Validation Rule: Cross Manifest Validation - Union Improve the error handling on cross-validation rule
2 participants
@GiaJordan @milen-sage