[SYNPY-1686] Suport Pattern column in data model #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
changed the title
thomasyu888
reviewed
Nov 26, 2025
thomasyu888
reviewed
Nov 26, 2025
BryanFauble
approved these changes
Nov 26, 2025
Member
BryanFauble
left a comment
BryanFauble
left a comment
There was a problem hiding this comment.
Thanks for this! The changes look good to me.
SageGJ
commented
Nov 26, 2025
andrewelamb
requested changes
Dec 1, 2025
andrewelamb
requested changes
Dec 1, 2025
andrewelamb
requested changes
Dec 1, 2025
andrewelamb
approved these changes
Dec 1, 2025
linglp
reviewed
Dec 1, 2025
tests/unit/synapseclient/extensions/schema_files/data_models/example.model.csv
Outdated
Show resolved
Hide resolved
tests/unit/synapseclient/extensions/schema_files/data_models/example.model.csv
Outdated
Show resolved
Hide resolved
thomasyu888
reviewed
Dec 4, 2025
andrewelamb
reviewed
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It is necessary to switch from using validation rules to specify regex validation to specifying the regex pattern in a column of the data model.
Solution:
A new optional column has been added to the data model and the use of the regex validation rule has been deprecated.
Testing:
Tests have been updated as well as testing data.
Testing also uncovered a new bug causing failing tests, tracked here