fix(libbox): prevent goroutine leak in ExchangeContext.OnCancel#4167
Open
hklcf wants to merge 1 commit into
Open
fix(libbox): prevent goroutine leak in ExchangeContext.OnCancel#4167hklcf wants to merge 1 commit into
hklcf wants to merge 1 commit into
Conversation
The OnCancel goroutine blocked indefinitely on c.context.Done(). If the context was never cancelled, the goroutine leaked. Add a timeout via time.After with DNSTimeout to ensure termination. Fixes SagerNet#4162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
\ExchangeContext.OnCancel()\ at \experimental/libbox/dns.go:122-127\ spawns a goroutine that blocks on \c.context.Done(). If the context passed to \Exchange()\ is never cancelled (e.g., caller does not set a deadline or cancellation), the goroutine leaks indefinitely.
Fix
Add a \select\ with \ ime.After(C.DNSTimeout)\ as a fallback to ensure the goroutine terminates even if the context is never done.
Related Issue
Fixes #4162