Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented interface ISender, Sender -> ISender #21

Merged
merged 1 commit into from
Oct 10, 2017
Merged

implemented interface ISender, Sender -> ISender #21

merged 1 commit into from
Oct 10, 2017

Conversation

unzeitigm
Copy link
Contributor

Hi, in response to #20 and for preserving the BC, I've added an ISender interface and an EmptySender class and I would like to ask if this is a reliable solution?

We've been dealing with this in our company for a while. PPL support told us that we must ommit the Sender when sending shipment package data. When sending pallet data, Sender is required. As for labels, Sender is always required.

How do you feel about this?

@Salamek
Copy link
Owner

Salamek commented Oct 9, 2017

@unzeitigm
Hi, funny thing is that my customers use createPackages with sender filled in since this lib exists and there was no issue reported from PPL 😄

So issue #20 was first time i heard about it...
Having ISender is good thing anyway (when we have this one, maybe we should use Interfaces for all models later...)

If this solution works for you guys, i have only one remark:

  • Pls update README.md to reflect this changes (Section Create Packages) to keep our "docs" updated.

Then i will merge this PR

Added EmptySender because of BC
- Sender must be omitted when sending package (not pallet) data

Api: Check instance type of ISender

Readme updated
@unzeitigm
Copy link
Contributor Author

@Salamek
Done. I've also added checking instance type of ISender in API's createPackages() method.

... funny it is indeed :D Firstly they wanted us to remove the Sender ... then another guy didn't care really much, and then the first guy again started complaining and demanded not sending the Sender ... :D

@Salamek Salamek merged commit f07c88e into Salamek:master Oct 10, 2017
@unzeitigm unzeitigm deleted the emptySender branch October 11, 2017 06:34
@Salamek Salamek mentioned this pull request Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants