Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-15006946 - Release v2.14.0 #399

Merged
merged 7 commits into from
Mar 5, 2024
Merged

@W-15006946 - Release v2.14.0 #399

merged 7 commits into from
Mar 5, 2024

Conversation

alexvuong
Copy link
Contributor

Release for adding new. Shopper SEO APIs

@alexvuong alexvuong requested a review from a team as a code owner March 2, 2024 00:49
@alexvuong
Copy link
Contributor Author

Note: I pushed forced because I made a mistake that having 2.13.1 version in the commits. I rebased locally and fixed up that commit.

@alexvuong alexvuong changed the title @W-15006946 - Release/20240301 @W-15006946 - Release v2.14.0 Mar 4, 2024
joeluong-sfcc
joeluong-sfcc requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@joeluong-sfcc joeluong-sfcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, otherwise LGTM. You'll also have to update the git tag to point to the updated commit with the revised changes

apis/product/shopper-products/shopper-products.raml Outdated Show resolved Hide resolved
@joeluong-sfcc joeluong-sfcc mentioned this pull request Mar 4, 2024
Merged
joeluong-sfcc
joeluong-sfcc reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@joeluong-sfcc joeluong-sfcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I forgot that you'll also have to re-run the docs command since the docs now reflect the incorrect shopper products RAML:

Screenshot 2024-03-04 at 5 57 58 PM

expand should be type array and not string

joeluong-sfcc
joeluong-sfcc approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@joeluong-sfcc joeluong-sfcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling the release

@alexvuong alexvuong merged commit ce25717 into main Mar 5, 2024
8 checks passed
@alexvuong alexvuong deleted the release/20240301 branch March 5, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendvc bendvc bendvc approved these changes

@joeluong-sfcc joeluong-sfcc joeluong-sfcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexvuong @bendvc @joeluong-sfcc