BGE: Use picklist for Payment Method in form #3647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
**lurch: attach W-028258 |
|
Tracking W-028258 |
lmeerkatz
reviewed
Sep 18, 2018
| if (col.type == 'date') { | ||
| col.type = 'date-local'; | ||
| } | ||
|
|
||
| // special case for payment type to fetch picklist values | ||
| // TODO: consider abstracting this out to dynamically check for data type of mapped field? |
There was a problem hiding this comment.
I don't want a hard-coded solution for this. Let's hold off on implementing this work for now. I'd close this PR without merging, but link to it from the story so we have this to start from when we're ready to pick this back up.
|
Closing to come back to this work later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical Changes
Changes
--Payment Method now renders as a picklist and draws its options from the active picklist values on the Payment Method field on Payment.
Issues Closed
New Metadata
Deleted Metadata