Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HRDPS change from west domain to continental domain #156

Merged
merged 71 commits into from
Mar 15, 2023

Conversation

douglatornell
Copy link
Member

ECCC dropped the HRDPS west polar stereographic grid product that we were using in favour of the continental rotated lat-lon grid product on 22-Feb-2023.

ECCC stopped producing 2.5km HRDPS west product on 22-Feb-2023. It was part of
the polar stereographic grid product suite that they replaced with the rotated
lat-lon grid product, but that product is only available for the continental
domain.
Replaces --yesterday option. ECCC hpfx server holds ~60 days of archived
model products. So, we now have the option of downloading for dates further into
the past than just the previous day.
@douglatornell douglatornell added bug Something isn't working Workers config Automation configuration labels Feb 24, 2023
@douglatornell douglatornell added this to the v23.1 milestone Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@46f6588). Click here to learn what that means.
The diff coverage is 91.79%.

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage        ?   75.71%           
=======================================
  Files           ?      127           
  Lines           ?    16839           
  Branches        ?     1199           
=======================================
  Hits            ?    12750           
  Misses          ?     4038           
  Partials        ?       51           
Flag Coverage Δ
unittests 75.71% <91.79%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_config.py 100.00% <ø> (ø)
nowcast/workers/grib_to_netcdf.py 75.40% <72.95%> (ø)
nowcast/next_workers.py 97.91% <100.00%> (ø)
nowcast/workers/collect_weather.py 95.34% <100.00%> (ø)
nowcast/workers/download_weather.py 97.05% <100.00%> (ø)
tests/test_next_workers.py 99.33% <100.00%> (ø)
tests/workers/test_collect_weather.py 99.62% <100.00%> (ø)
tests/workers/test_download_weather.py 100.00% <100.00%> (ø)
tests/workers/test_grib_to_netcdf.py 100.00% <100.00%> (ø)
tests/workers/test_make_forcing_links.py 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglatornell douglatornell added the documentation Improvements or additions to documentation label Feb 24, 2023
Includes part of work required for issue #23
Includes part of work required for issue #23
Use SalishSeaCast branch in SalishSeaCast/pywgrib2_xr fork to work under
Python 3.10 and xarray>=2022.11. Also requires installation of libwgrib2
from SalishSeaCast branch in SalishSeaCast/libwgrib2 fork.
Includes part of work required for issues #23 and #43
Mostly to trigger another workflow run with tweaked setup.py in the pywgrib2_xr
fork.
Mostly to trigger another workflow run with tweaked setup.py in the pywgrib2_xr
fork.
Artefact of early days of SalishSeaNowcast development before automation
included assurance that
Handles finicky details of pywgrib2_xr.wgrib():
* all pywgrib2_xr.wgrib() args must be strings
* files must be freed after use to close them
Includes part of work required for issues #23 and #43
Includes part of work required for issue #23.
Total cloud in percent that was used for parametrization of radiation missing
from 2007-2014 GEMLAM. No longer needed.
"time", "longitude", and "latitude" variables from GRIB files are replaced by
time_counter, "nav_lon", and "nav_lat" in NEMO datasets, so they are unneeded.
Necessary so that we can use xarray.combine_by_coords() to build 3-section
run-date dataset.
Reduces grib_to_netcdf memory footprint and processing time a little compared to
using dask's default threads scheduler.
Also improve test coverage of _write_netcdf().
@douglatornell
Copy link
Member Author

Susan did checks on generated netCDF files at various points, comparing them to those generated by the old version of grib_to_netcdf with acceptable results.

I ran nowcast-green/16feb23 on arbutus using files generated by the new grib_to_netcdf. Susan compared the results of that run with those from that day's production with acceptable results.

@douglatornell douglatornell marked this pull request as ready for review March 15, 2023 16:32
@douglatornell douglatornell merged commit 3fef051 into main Mar 15, 2023
@douglatornell douglatornell deleted the hrdps-continental branch March 15, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config Automation configuration documentation Improvements or additions to documentation Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant