Get with file does not callback #1

Closed
msimr opened this Issue Sep 22, 2011 · 6 comments

Comments

Projects
None yet
2 participants

msimr commented Sep 22, 2011

I get into a file and the callback is never triggered.

http.get({url:url}, encryptedURL, function (err, res) {console.log(err,res);});

This never prints in my case.

However the file is downloaded without errors.

Owner

SaltwaterC commented Sep 23, 2011

Scratch the previous part. It appears to be an issue. I'll have a proper look.

Owner

SaltwaterC commented Sep 23, 2011

Happens only with multiple data events when the gzbz2 module is missing.

Owner

SaltwaterC commented Sep 23, 2011

There was a pretty subtle race condition there. In single data event cases, the end of transfer event was fired before the write stream file descriptor was available. I made a workaround that broke the other case: having the fd available before the end of transfer event kicks in. I'll update the test coverage to properly assert these conditions, both with gzip enabled and disabled.

msimr commented Sep 23, 2011

I'm testing it on my side will keep you posted with the results.

msimr commented Sep 23, 2011

Works fine.

Thanks for the fix!

Owner

SaltwaterC commented Sep 23, 2011

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment