-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hono (bun) impl. for 20% speed boost #59
Comments
Benchmarks should use 127.0.0.1 (IPv4) instead of the name 'localhost', due to potential IPv6 overhead or conflict: don't use localhost (intermediate) anthony explains (4 min). |
I agree with the benchmark of 127.0.0.1 benchmark part, but disagree with the hattip part:
Basically, in any server more complex than hello world app, you are likely going to implemented either reverse proxy, micro-service or load balancing for multiple endpoint, eg. staging:
Setting the host ahead of time rejects all of the above implementation. Additionally, the 20% speed boost is not only limited to Hono, but Elysia, Stric, Vixeny and most frameworks are going to benefit the speed boost as well since the hostname is known ahead of time, we can just omit the hostname entirely. But we assume that the API staging or load balancing / reverse proxy will be implemented, that optimization doesn't match the real use case. |
That was my point actually. When I ran the tests a couple of months ago, some of the tested frameworks assumed a certain host name (vixeny's |
Didn't realize Stric and Vixen hardcode basename. |
@SaltyAom Would be awesome if you could update the README with the new bench results. It currently says |
Hello, I was looking at issues and I stumble upon this conversation, the reason why I added It should be fixed by the next benchmark sorry for the trouble xd. |
@redbar0n Stric was abandoned for a while. |
according to hattipjs/hattip#114 (comment)
The text was updated successfully, but these errors were encountered: