Set User in result page struct #80

Merged
merged 1 commit into from Sep 30, 2012

Conversation

Projects
None yet
2 participants
Contributor

rtomayko commented Sep 30, 2012

The top-level 'User' attribute in the result JSON is set to 'unknown user' in PageTimerStruct and never updated to a real value anywhere that I can see. It's useful to have a valid value here for troubleshooting issues with users stomping and stealing each other's results.

Also uses the already calculated value to prevent creating a new Rack::Request each time the user is needed as happens with the default user provider.

This is just something I was playing around with while troubleshooting and figured I'd send it over. No biggie if it isn't interesting to you.

Set User in result page struct
The page['User'] is set to 'unknown user' in PageTimerStruct and
never updated to a real value anywhere that I can see. It's useful
to have a valid value here for troubleshooting issues with users
stomping and stealing each other's results.

SamSaffron added a commit that referenced this pull request Sep 30, 2012

Merge pull request #80 from rtomayko/user-in-results
Set User in result page struct

@SamSaffron SamSaffron merged commit 456b637 into SamSaffron:master Sep 30, 2012

Owner

SamSaffron commented Sep 30, 2012

looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment