Check existing jQuery version #87

Merged
merged 1 commit into from Oct 8, 2012

Projects

None yet

2 participants

@josh

Tested MiniProfiler working back to jQuery 1.4.0. Though, I don't think we want to support that far back. Its probably safe to require a minimal of whatever version MiniProfiler bundles itself, thats 1.7.x. I feel pretty confident that 1.9.x, the last 1.x version of jQuery, is going to work fine in the future. So 1.7.x to 2.x seems like a good version constraint.

I removed useExistingJquery from a few spots in the ruby code, but I'm not sure about the .net code path. It'd probably be good to ensure that any existing configuration code setting useExistingJquery doesn't explode, but is just silent.

@josh josh Ensure existing jQuery is 1.7.x < N < 2.x
Deprecates useExistingjQuery option
fd2d590
@josh

I also tend to aggressively upgrade our code to the latest jquery and sometimes unreleased versions. So you'll definitely see some patches from me if 1.9.x ends up having issues with MiniProfiler.

@SamSaffron SamSaffron merged commit 24f3d8f into SamSaffron:master Oct 8, 2012
@SamSaffron
Owner

I wonder if we want a stub and deprecation notice so we don't break apps for the next release?

@josh

I already stubbed the ruby version, but it doesn't do any sort of verbose warning. For ruby, its pretty easy:

def use_existing_jquery=(v)
  warn "MiniProfiler.config.use_existing_jquery is deprecated"
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment