You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we intercept ⌘F (and ^F on non-macOS) and redirect it to our search field. However, this means that people cannot search on the page. Maybe we should do what GitHub does and use / as the search shortcut. If we replace this:
then / selects the search field, but doesn't type into it. We'd need to only sometimes use e.preventDefault(), depending on whether the search field was selected, but that should be doable.
We should also have the little hint that GitHub has in its search bar that shows that / selects it.
The text was updated successfully, but these errors were encountered:
Currently, we intercept ⌘F (and ^F on non-macOS) and redirect it to our search field. However, this means that people cannot search on the page. Maybe we should do what GitHub does and use
/
as the search shortcut. If we replace this:samasaur1.github.io/_includes/navigation.html
Lines 44 to 51 in 473bf35
with the following JavaScript:
then
/
selects the search field, but doesn't type into it. We'd need to only sometimes usee.preventDefault()
, depending on whether the search field was selected, but that should be doable.We should also have the little hint that GitHub has in its search bar that shows that
/
selects it.The text was updated successfully, but these errors were encountered: