Add Tor Support #11
Merged
Add Tor Support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Alamofire5: Update creation of PushTx request to Alamofire5 API Update Moya to 14.0.0 (includes Alamofire 5.1.0)
Sends "SIGNAL RELOAD" and "SIGNAL NEWNYM" to the Tor thread
TODO: replace png with pdf
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Tor support for all requests made to the Samourai backend. The iCepa Tor.framework is used and integrated via Carthage.
This PR is split up into smaller pull requests to make review and discussion easier. Merge these to develop first and this PR will get smaller. In order:
As a follow-up PR I would love to implement testnet support for both the regular and the Tor API, as seen on Android.
Inspiration for network settings UI taken from Android:
Tor setting is stored in the iOS user defaults and checked on startup. If set, Tor is initialized before the home screen is shown.
ℹ️ Note: If a PIN is set, Tor is initialized after the PIN was entered correctly. This behavior is different from Android, which initialized Tor before everything else. If we want to have the same behavior on iOS, we will have to do quite a bit of refactoring, especially how the view controller stack is initialized in
RootNavigationViewController. I tried to implement an acceptable solution with minimal unrelated changes, to not blow up this PR unnecessarily. I suggest we create a separate PR to refactor and improve this behavior after this one is merged.