Fixed debugger build on TizenRT. #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jerryscript-project/jerryscript#2586 is also needed. |
LaszloLango
force-pushed
the
fix-debugger-build-on-tizenrt
branch
from
e5cd14c
to
04ac36d
Compare
LaszloLango
changed the title
|
The PR is ready for review, tested locally. Builds successfully when jerryscript-project/jerryscript#2586 is applied. I opened a PR (#1791) for the necessary JerryScript update. |
|
May I suggest you to rebase on master and push again |
TizenRT should not build the default port implementation of the JerryScript engine. TizenRT port defines its own port implementation in the 'iotjs_main_tizenrt.c' file. Added missing 'jerry_port_sleep' implementation if JerryScript debugger is enabled. IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
fix-debugger-build-on-tizenrt
branch
from
04ac36d
to
06c9006
Compare
|
@rzr of course, the patch is rebased. |
|
ok https://travis-ci.org/Samsung/iotjs/jobs/452746615 is Verified for tizenrt (using CI's defconfig) |
|
@rzr thank your for checking it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TizenRT should not build the default port implementation of the
JerryScript engine. TizenRT port defines its own port implementation
in the 'iotjs_main_tizenrt.c' file. Added missing 'jerry_port_sleep'
implementation if JerryScript debugger is enabled.
IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com