Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rules for cookies are currently only able to be applied to all cookies. This PR adds a cookie validator so that rules can be applied on a per-cookie basis. For example:
As the validation methods were getting a bit long doing header, directive and cookie validations, I've created separate validator classes for each
Type of change
What types of changes do you want to introduce to DrHeader?
Please ensure your pull request adheres to the following guidelines:
Link to the github issue
#228
Tests you have added
test_validators.py
test_drheader.py:
test_cookie__exists_validation_ko
test_cookie__not_exists_validation_ko
test_cookie__must_avoid_validation_ko
test_cookie__must_contain_validation_ko
test_cookie__must_contain_one_validation_ko
Anything Else
Thanks for getting this far !