Validation errors with Mesa/Intel on SKL

[eero-t]

These are the validation errors with today's VulkanTools & Mesa, some seem bugs in the demos, some are about missing features.

Errors about not destroying some objects before destroying the device, in:

• computecullandlod
• computenbody
• triangle

For example:
ObjectTracker(ERROR): object: 0x53 type: 5 location: 363 msgCode: 49: OBJ ERROR : For device 0x2574b20, Semaphore object 0x53 has not been destroyed. For more information refer to Vulkan Spec Section '4.2.4. Device Destruction' which states 'All child objects created on device must have been destroyed prior to destroying device' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#vkDestroyDevice)

For "debugmarker":
ParameterValidation(ERROR): object: 0x0 type: 0 location: 4860 msgCode: 10: vkDebugMarkerSetObjectNameEXT() called even though the VK_EXT_debug_marker extension was not enabled for this VkDevice.

For "deferredmultisampling":

SC(ERROR): object: 0x0 type: 3 location: 1776 msgCode: 3: Vertex shader consumes input at location 0 but not provided
SC(ERROR): object: 0x0 type: 3 location: 1776 msgCode: 3: Vertex shader consumes input at location 1 but not provided

For "deferredshadows":

../../../../src/intel/vulkan/anv_image.c:207: FINISHME: Implement multi-arrayLayer HiZ clears and resolves
DS(ERROR): object: 0x263b080 type: 6 location: 4334 msgCode: 6: Cannot submit cmd buffer using image (0x64) [sub-resource: aspectMask 0x4 array layer 0, mip level 0], with layout VK_IMAGE_LAYOUT_UNDEFINED when first use is VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL.

In following tests:

• mesh
• multisampling
• offscreen
• pushconstants
• scenerendering

SC(ERROR): object: 0x0 type: 0 location: 2407 msgCode: 15: Shader requires VkPhysicalDeviceFeatures::shaderClipDistance but is not enabled on the device

In "raytracing":
SC(ERROR): object: 0x0 type: 0 location: 10469 msgCode: 5: SPIR-V module not valid: OpStore Pointer <id> '227's type does not match Object <id> '212's type.

In "terraintessellation":

DL(ERROR): object: 0x0 type: 2 location: 4163 msgCode: 5: While calling vkCreateDevice(), requesting feature #24 in VkPhysicalDeviceFeatures struct, which is not available on this device.
DL(ERROR): object: 0x0 type: 2 location: 4174 msgCode: 5: You requested features that are unavailable on this device. You should first query feature availability by calling vkGetPhysicalDeviceFeatures().
Fatal : VkResult is "ERROR_INCOMPATIBLE_DRIVER" in terraintessellation/terraintessellation.cpp at line 193
terraintessellation: /home/testrunner/work/VulkanSachaWillems/terraintessellation/terraintessellation.cpp:193: void VulkanExample::setupQueryResultBuffer(): Assertion `res == VK_SUCCESS' failed.
Aborted (core dumped)

(Works if one applies this: https://patchwork.freedesktop.org/series/15841/ )

For "textoverlay":
SC(ERROR): object: 0x0 type: 0 location: 1579 msgCode: 3: fragment shader consumes input location 4.0 which is not written by vertex shader

For "texturesparseresidency":

DL(ERROR): object: 0x0 type: 2 location: 4163 msgCode: 5: While calling vkCreateDevice(), requesting feature #42 in VkPhysicalDeviceFeatures struct, which is not available on this device.
DL(ERROR): object: 0x0 type: 2 location: 4163 msgCode: 5: While calling vkCreateDevice(), requesting feature #43 in VkPhysicalDeviceFeatures struct, which is not available on this device.
DL(ERROR): object: 0x0 type: 2 location: 4174 msgCode: 5: You requested features that are unavailable on this device. You should first query feature availability by calling vkGetPhysicalDeviceFeatures().
Device does not support sparse residency for 2D images!

[SaschaWillems]

Most of these are not specific to MESA and are on my todo-list.

For the ones not destroying objects I'll take a look at these. I'm usually very pedantic with releasing Vulkan objects, though it's possible that some objects may be recreated during resize (which is wrong anyway).

The the ones failing due to non-supported features (tessellation, sparse) are supposed to do so.

The ones with VkPhysicalDeviceFeatures::shaderClipDistance are triggered becaus those shaders haven't been regenerated with a recent glslang validator version.

[eero-t]

The ones failing due to non-supported features (tessellation, sparse) are supposed to do so.

I listed everything for completeness sake. Mesa does support tessellation with Vulkan (was added few weeks ago), in that tessellation test, the issue is missing query support.

[eero-t]

FYI: Mesa/Intel has currently also this issue with Vulkan: https://bugs.freedesktop.org/show_bug.cgi?id=99507

[SaschaWillems]

Thx, I'm aware of this as I'm also testing examples on Intel with Mesa from time to time.

[eero-t]

There aren't anymore validation errors for the update tests: Triangle, offscreen & textoverlay.

[eero-t]

Verified the changes. Warnings remain in:

• deferredmultisampling
• deferredshadows
• raytracing

And in tests where Mesa still misses required functionality:

• terraintessellation
• texturesparseresidency

[SaschaWillems]

Thanks for the verfication. Deferredshadows is still open due to a possible validation layer bug (see #238) and raytracing may be a bug in the SPIR-V validation layers (still checking on this).