New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to define tracking, either through googleAnalytics or trackingCode #10

Merged
merged 2 commits into from Oct 12, 2014

Conversation

Projects
None yet
4 participants
@HugoGiraudel
Member

HugoGiraudel commented Oct 11, 2014

@SassDoc/owners Please review.


Are we okay on key names (googleAnalytics and trackingCode)?

Or perhaps:

  • GAKey
  • GATrackingKey
  • googleAnalyticsTrackingKey

And:

  • tracking
  • trackingSnippet

Thoughts?

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 11, 2014

Member

googleAnalytics and trackingCode are fine to me.

Member

valeriangalliat commented Oct 11, 2014

googleAnalytics and trackingCode are fine to me.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Oct 11, 2014

Member

googleAnalytics and trackingCode 👍

Member

FWeinb commented Oct 11, 2014

googleAnalytics and trackingCode 👍

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Oct 11, 2014

Member

googleAnalytics and trackingCode are straightforward enough.

Member

pascalduez commented Oct 11, 2014

googleAnalytics and trackingCode are straightforward enough.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 11, 2014

Member

Perfect. Can one of you review the code to make sure it's okay? :)

Member

HugoGiraudel commented Oct 11, 2014

Perfect. Can one of you review the code to make sure it's okay? :)

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 12, 2014

Member

Not sure with the else if part… some websites use not only Google Analytics but a bunch other tracking systems. But in this case they can just put everything in the trackingCode anyway.

Otherwise everything is fine, you can merge (the above is an edge case anyway, at least for code documentation websites).

Member

valeriangalliat commented Oct 12, 2014

Not sure with the else if part… some websites use not only Google Analytics but a bunch other tracking systems. But in this case they can just put everything in the trackingCode anyway.

Otherwise everything is fine, you can merge (the above is an edge case anyway, at least for code documentation websites).

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 12, 2014

Member

I'll make 2 separate if.

Member

HugoGiraudel commented Oct 12, 2014

I'll make 2 separate if.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 12, 2014

Member

Okay, let's merge this on develop. There is a PR pending to add documentation to site, but we won't merge it until this goes live.

Member

HugoGiraudel commented Oct 12, 2014

Okay, let's merge this on develop. There is a PR pending to add documentation to site, but we won't merge it until this goes live.

HugoGiraudel added a commit that referenced this pull request Oct 12, 2014

Merge pull request #10 from SassDoc/tracking-feature
Added the ability to define tracking, either through googleAnalytics or trackingCode

@HugoGiraudel HugoGiraudel merged commit e3c771a into develop Oct 12, 2014

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Oct 12, 2014

Member

@HugoGiraudel Maybe we need some kind of develop on sassdoc.github.io?

Member

valeriangalliat commented Oct 12, 2014

@HugoGiraudel Maybe we need some kind of develop on sassdoc.github.io?

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Oct 12, 2014

Member

Might be interesting.

Member

HugoGiraudel commented Oct 12, 2014

Might be interesting.

@HugoGiraudel HugoGiraudel deleted the tracking-feature branch Nov 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment