Consider @output for mixins #133

Closed
HugoGiraudel opened this Issue Jul 23, 2014 · 6 comments

Comments

Projects
None yet
4 participants
@HugoGiraudel
Member

HugoGiraudel commented Jul 23, 2014

Mixins do not return a value, they output code. what about a @output annotation exclusively for mixins?

Now, either we keep things simple:

/**
 * @output Description
 */

Or we want complicated things where we list all properties that can be output.

/**
 * @output font-family, font-weight, color
 */

Any thought?

@HugoGiraudel HugoGiraudel added this to the 1.3 milestone Jul 23, 2014

@HugoGiraudel HugoGiraudel self-assigned this Jul 23, 2014

@pascalduez

This comment has been minimized.

Show comment
Hide comment
@pascalduez

pascalduez Jul 23, 2014

Member

I'm totally found of this. I used to write something like // @print Description before SassDoc.
Example here
Then removed them since there was no equivalent.

I would go with the simple option:

/**
 * @output Description
 */
Member

pascalduez commented Jul 23, 2014

I'm totally found of this. I used to write something like // @print Description before SassDoc.
Example here
Then removed them since there was no equivalent.

I would go with the simple option:

/**
 * @output Description
 */
@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 24, 2014

Member

@FWeinb @valeriangalliat I know you guys don't do Sass much but I'd like your opinion nevertheless.

Member

HugoGiraudel commented Jul 24, 2014

@FWeinb @valeriangalliat I know you guys don't do Sass much but I'd like your opinion nevertheless.

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Jul 24, 2014

Member

Let's do it.

Member

FWeinb commented Jul 24, 2014

Let's do it.

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Jul 24, 2014

Member

I take this for 1.3.

Member

HugoGiraudel commented Jul 24, 2014

I take this for 1.3.

@valeriangalliat

This comment has been minimized.

Show comment
Hide comment
@valeriangalliat

valeriangalliat Jul 24, 2014

Member

This sounds like a good idea. 👍

Member

valeriangalliat commented Jul 24, 2014

This sounds like a good idea. 👍

@HugoGiraudel HugoGiraudel modified the milestone: 1.3 Jul 24, 2014

@HugoGiraudel HugoGiraudel removed the 1.3 label Jul 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment